Re: [PATCH] firmware: Update hotplug script, remove sysfs files

From: Magnus Damm
Date: Mon Jun 28 2010 - 02:17:30 EST

On Sat, Jun 26, 2010 at 3:22 AM, Greg KH <greg@xxxxxxxxx> wrote:
> On Fri, Jun 25, 2010 at 05:55:11PM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@xxxxxxxxxxxxx>
>> Update the in-kernel hotplug example script to work
>> properly with recent kernels. Without this fix the
>> script may load the firmware twice - both at "add"
>> and "remove" time.
>> The second load only triggers in the case when multiple
>> firmware images are used. A good example is the b43
>> driver which does not work properly without this fix.
>> While at it, make sure sysfs files are removed.
> Hm, the documentation update applied, but this second part didn't.  Care
> to redo it against the linux-next tree and resend it as a separate
> patch?  I've split this up and applied the documentation part now, so
> you don't have to redo that.

Thanks a lot for splitting up the patch. I don't mind redoing the
second part of the patch, but I'm not sure if it's actually needed to
prevent memory leaks. This piece of code serves as an example:

+ sysfs_remove_bin_file(&f_dev->kobj, &fw_priv->attr_data);

Perhaps device_unregister() call above already removes the kobj which
makes the added sysfs_remove_bin_file() unnecessary?


/ magnus
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at