Re: [PATCH 1/5] staging: slicoss: Change return codes to -EYYY.

From: Denis Kirjanov
Date: Mon Jun 28 2010 - 10:13:08 EST

On 06/28/2010 03:14 PM, Kulikov Vasiliy wrote:
@@ -1206,7 +1206,7 @@ static void slic_link_event_handler(struct adapter *adapter)
Stop compilation;
- ASSERT((status == STATUS_SUCCESS) || (status == STATUS_PENDING));
+ ASSERT(status == 0);

Now that looks useless since slic_upr_request can return STATUS_PENDING
or -ENOMEM. Same for slic_config_get
Yes, it seems that slic_link_event_handler& slic_config_get have to return error codes.

@@ -2267,7 +2267,7 @@ static u32 slic_card_locate(struct adapter *adapter)

if (!card)
+ return -ENOMEM;

Is -ENOMEM correct for this case?

Right, maybe ENXIO?

Yes, I'm fine with this.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at