Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' set butnot used

From: Justin P. Mattock
Date: Mon Jun 28 2010 - 13:48:14 EST

On 06/28/2010 05:38 AM, David Howells wrote:
Justin P. Mattock<justinmattock@xxxxxxxxx> wrote:

In this case the safest approach(in my mind) would be to just
mark the integer __unused. Keep in mind though Im not certain
if this is the right place for this value i.e. will this effect
*instkey or not(please check).

This is the wrong approach. Either the variable should be got rid of, or it
should be used to replace all the other calls to key_ref_to_ptr() in


I see your patch you sent for this.. vary nice!


Justin P. Mattock
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at