Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but notused

From: Justin P. Mattock
Date: Mon Jun 28 2010 - 15:03:26 EST

On 06/28/2010 11:47 AM, David Howells wrote:
Justin P. Mattock<justinmattock@xxxxxxxxx> wrote:

would just removing ret be good or will things go out of whack because of no

Don't you then get warnings for not capturing the result?


not sure if it would give warnings for not capturing the result.
then doing this would be the way to go.

if (ret) {
printk(KERN_WARNING "dev%d: Failed to create physical_node sysfs link: %d\n");

but like you had said unnecessary braces, and only one statement
I'll look at this some more too see if I come up with anything.

Justin P. Mattock
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at