Re: [PATCH] Ext4: Make file creation time, i_version and i_generation available by xattrs
From: Andreas Dilger
Date: Mon Jun 28 2010 - 15:09:20 EST
On 2010-06-28, at 10:26, David Howells wrote:
> Make the file creation time, inode data version number and inode generation
> number available on Ext4 by as xattrs named:
> file.i_version (directories only for ext4)
Some minor nits:
- I'd prefer calling these "file.generation" and "file.version".
I don't think there is value in the "i_" prefix adds anything,
and it seems more like an internal detail to me
- why not expose the ".version" field for regular files? It seems
that all of them are applicable for all file types.
- it would be good to not introduce a new xattr namespace, since
tools like tar (even the RHEL-patched one) will not backup and
restore these namespaces. Using "trusted." would allow them to
be backed up and restored using existing xattr-patched GNU tar
by root, but wouldn't allow them to be modified by regular users.
I think this is important for proper backup/restore of a filesystem,
but can have correctness implications and shouldn't be accessible
to regular users.
Is this a binary (host-endian) struct timespec?
This seems odd, i_generation should never be zero, AFAIK.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/