Re: [PATCH 1/1] ACPI: pci_irq, add PRT_ quirk for IBM Bartolo

From: Robert Hancock
Date: Mon Jun 28 2010 - 17:37:45 EST


On Mon, Jun 28, 2010 at 2:48 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> On Mon, Jun 28, 2010 at 10:12:53PM +0200, Jiri Slaby wrote:
>> On 06/28/2010 07:14 PM, Matthew Garrett wrote:
>> > http://www-07.ibm.com/hk/products/pos/300/specs.html indicates that
>> > Windows is supported on this hardware. It would be good to verify that
>> > it also fails before we try a model-specific quirk.
>>
>> It would be good for what? I don't see the point, DSDT is broken on that
>> machine and the patch works this around. Why do we need testruns from
>> Windows? And why you think Windows will fail anyway, they can very have
>> the pretty same quirk there.
>
> I can guarantee to you that a generic Windows install does not have a
> quirk for an IBM PoS system released years after that CD was pressed.
> The relevance is that if Windows works without a quirk, then somewhere
> our behaviour diverges from that of Windows and it's likely that other
> machines are also hit by the same issue. Users of those systems may not
> have a support contract with a commercial Linux vendor and may just
> decide to use Windows instead, so there's an incentive for us to
> determine if that's the case and fix Linux's behaviour to match Windows
> rather than to just quirk over it.

Exactly, this seems like a pretty obvious failure, so either IBM's
testing on this machine under Windows was hopelessly inadequate and it
is broken there too, or else Windows is doing something different and
maybe we should be doing the same thing..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/