[Bugfix] [2.6.35-rc3-tip] perf build failure on latest tip.

From: Srikar Dronamraju
Date: Tue Jun 29 2010 - 13:37:52 EST

When compiling perf on latest tip/master
I see the following error

cc1: warnings being treated as errors
util/newt.c: In function â??hist_entry__tui_annotateâ??:
util/newt.c:764: warning: â??retâ?? is used uninitialized in this function
make: *** [util/newt.o] Error 1

I think the problem was introduced by commit

Below is a patch that fixes the problem.

Signed-off-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c
index 89c52fc..06f248f 100644
--- a/tools/perf/util/newt.c
+++ b/tools/perf/util/newt.c
@@ -753,7 +753,7 @@ int hist_entry__tui_annotate(struct hist_entry *self)

browser.width += 18; /* Percentage */
ui_browser__show(&browser, self->ms.sym->name);
- ui_browser__run(&browser, &es);
+ ret = ui_browser__run(&browser, &es);
list_for_each_entry_safe(pos, n, &head, node) {
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/