Re: [RFC][PATCH 09/11] perf: Default PMU ops

From: Peter Zijlstra
Date: Tue Jun 29 2010 - 14:19:18 EST


On Tue, 2010-06-29 at 20:11 +0200, Frederic Weisbecker wrote:
> On Tue, Jun 29, 2010 at 08:09:10PM +0200, Peter Zijlstra wrote:
> > On Tue, 2010-06-29 at 20:07 +0200, Frederic Weisbecker wrote:
> > > On Tue, Jun 29, 2010 at 06:34:10PM +0200, Peter Zijlstra wrote:
> > > > On Tue, 2010-06-29 at 17:03 +0200, Frederic Weisbecker wrote:
> > > > > > You mean, if (!pmu->start_txn && pmu->pmu_enable) { /* install defaults
> > > > > > */ } ?
> >
> > > neglected pmu implementations shouldn't impact software pmus.
> >
> > With the above and not providing ->pmu_enable you get that.
>
>
> But we don't need to provide a pmu_enable for software events, right?

My point exactly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/