Re: should struct device.dma_mask still be a pointer?
From: Konrad Rzeszutek Wilk
Date: Wed Jun 30 2010 - 14:09:37 EST
On Tue, Jun 22, 2010 at 12:52:33PM +0200, Uwe Kleine-König wrote:
> IMHO it's strange that struct device.dma_mask is a pointer instead of a
> plain u64. The reason this was done back then is described in
> Attached is a patch which moves dma_mask into struct device and cleans up the
> scsi mid-layer to use it (instead of using struct pci_dev). The advantage to
> doing this is probably most apparent on non-pci bus architectures where
> currently you have to construct a fake pci_dev just so you can get the bounce
> buffers to work correctly.
> The patch tries to perturb the minimum amount of code, so dma_mask in struct
> device is simply a pointer to the one in pci_dev. However, it will make it
> easy for me now to add generic device to MCA without having to go the fake pci
> As I work on such a non-pci bus architecture it's still ugly that this
> is a pointer because I have to allocate extra memory for that.
> Is there a reason not to get rid of struct pci_dev.dma_mask and use
> struct pci_dev.dev.dma_mask instead? (Well apart from the needed
> effort of course.)
Lets CC Fujita. He has been redoing some of the DMA API, and making the
PCI DMA API be used in favour of the old DMA API.
But from the sounds of it for your architecture you need a DMA API, not
a PCI DMA and you want to merge the dma_mask in one? Preferably in the
struct device one?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/