Re: [V9fs-developer] [GIT PULL] 9p file system bug fixes for 2.6.35-rc2
From: Linus Torvalds
Date: Wed Jun 30 2010 - 14:31:52 EST
On Wed, Jun 30, 2010 at 11:16 AM, Latchesar Ionkov <lucho@xxxxxxxxxx> wrote:
> I think that you need to use the s_vfs_rename_mutex in the super_block
> struct instead of introducing a new rename_lock in the v9fs session.
I actually think it's better to avoid having filesystems muck around
with VFS locking details. Also, I think we get the VFS rename mutex
only for cross-directory renames, and as mentioned, 9p needs locking
even for regular directory renames.
(Also, this way you can have parallel readers - although we could
obviously change the vfs rename mutex into a rw-sem too).
So I do think that keeping the logic private to a 9p-specific lock is
the right solution here.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/