Re: [PATCH 07/11] oom: move OOM_DISABLE check from oom_kill_task to out_of_memory()

From: KOSAKI Motohiro
Date: Wed Jun 30 2010 - 20:07:54 EST


> On Wed, Jun 30, 2010 at 06:31:36PM +0900, KOSAKI Motohiro wrote:
> > Now, if oom_kill_allocating_task is enabled and current have
> > OOM_DISABLED, following printk in oom_kill_process is called twice.
> >
> > pr_err("%s: Kill process %d (%s) score %lu or sacrifice child\n",
> > message, task_pid_nr(p), p->comm, points);
> >
> > So, OOM_DISABLE check should be more early.
>
> If we check it in oom_unkillable_task, we don't need this patch.

Yup. but please read the commnet of [3/11].



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/