Re: [RFC 1/3] mm: iommu: An API to unify IOMMU, CPU and device memory management

From: Paul Mundt
Date: Fri Jul 02 2010 - 03:00:52 EST


On Thu, Jul 01, 2010 at 12:16:18AM -0700, Zach Pfeffer wrote:
> Thank you for the corrections. I'm correcting them now. Some responses:
>
> Randy Dunlap wrote:
> >> + struct vcm *vcm_create(size_t start_addr, size_t len);
> >
> > Seems odd to use size_t for start_addr.
>
> I used size_t because I wanted to allow the start_addr the same range
> as len. Is there a better type to use? I see 'unsigned long' used
> throughout the mm code. Perhaps that's better for both the start_addr
> and len.
>
phys_addr_t or resource_size_t.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/