Re: [PATCH] module: initialize module dynamic debug later

From: Linus Torvalds
Date: Fri Jul 02 2010 - 23:05:38 EST


On Fri, Jul 2, 2010 at 7:35 PM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> We should initialize the module dynamic debug datastructures
> only after determining that the module is not loaded yet. This
> fixes a bug that introduced in 2.6.35-rc2, where when a trying
> to load a module twice, we also load it's dynamic printing data
> twice which causes all sorts of nasty issues. Also handle
> the dynamic debug cleanup later on failure.
>
> Signed-off-by: Yehuda Sadeh <yehuda@xxxxxxxxxxxxxxx>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> (removed a #ifdef)

Is this missing a

From: Yehuda Sadeh <yehuda@xxxxxxxxxxxxxxx>

author attribution by any chance? The sign-offs imply so.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/