Re: [PATCH 4/6] block: remove BKL from BLKROSET and BLKFLSBUF

From: Christoph Hellwig
Date: Tue Jul 06 2010 - 21:52:37 EST


On Sat, Jul 03, 2010 at 11:47:18PM +0200, Arnd Bergmann wrote:
> We only call the functions set_device_ro(),
> invalidate_bdev(), sync_filesystem() and sync_blockdev()
> while holding the BKL in these commands. All
> of these are also done in other code paths without
> the BKL, which leads me to the conclusion that
> the BKL is not needed here either.
>
> The reason we hold it here is that it was originally
> pushed down into the ioctl function from vfs_ioctl.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/