Re: IPVS: Incorrect helper use for SCTP [was: wensong@linux-vs.org, horms@verge.net.au]

[xiaoyu Du]

This function is used  for sctp app heplers.
since  there's no sctp helpers yet at present, it does nothing.
If I make sure this is a bug. I will resend the pathch.


2010/7/7 Simon Horman <horms@xxxxxxxxxxxx>:
> [CCed netdev]
>
> Thanks,
>
> that looks correct to me. Have you tested this change?
> If so could you provided a Signed-off-by line
> as per section 12 of Documentation/SubmittingPatches?
>
> On Wed, Jul 07, 2010 at 05:19:06PM +0800, xiaoyu Du wrote:
>> Hiïall
>>
>> After I compared the sctp with tcp and udp, I thinkt his a bug that
>> sctp_dnat_handler Incorrectly invoked ip_vs_app_pkt_out.
>> below is the patch.
>>
>> ---
>> Ânet/netfilter/ipvs/ip_vs_proto_sctp.c | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/netfilter/ipvs/ip_vs_proto_sctp.c
>> b/net/netfilter/ipvs/ip_vs_proto_sctp.c
>> index c9a3f7a..db55759 100644
>> --- a/net/netfilter/ipvs/ip_vs_proto_sctp.c
>> +++ b/net/netfilter/ipvs/ip_vs_proto_sctp.c
>> @@ -173,7 +173,7 @@ sctp_dnat_handler(struct sk_buff *skb,
>> Â Â Â Â Â Â Â Â Â Â Â Âreturn 0;
>>
>> Â Â Â Â Â Â Â Â/* Call application helper if needed */
>> - Â Â Â Â Â Â Â if (!ip_vs_app_pkt_out(cp, skb))
>> + Â Â Â Â Â Â Â if (!ip_vs_app_pkt_in(cp, skb))
>> Â Â Â Â Â Â Â Â Â Â Â Âreturn 0;
>> Â Â Â Â}
>>
>> --
>> --
>> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/