Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number

[MichaÅ Nazarewicz]

> > >> This commit adds iSerialNumber to all gadgets that
> > use the Mass Storage Function.

On Thu, 08 Jul 2010 21:31:23 +0200, David Brownell <david-b@xxxxxxxxxxx> wrote:
> Can it be made to do so only when the gadget
> hasn't been provided with one already?  Serial
> number module options are standard parts of the
> composite gadget framework...

I don't see a way for the gadget to know whether user gave the iSerialNumber
parameter (other then reading the iSerialNumber variable but I consider that
ugly).

Plus, in any event, gadget has to reserve a string ID for serial number
anyway.  Otherwise composite won't override the string.


PS. I've just spotted a bug in Yann's patch (string is not filled if
CONFIG_USB_FILE_STORAGE_TEST is undefined).  It's a trivial issue so
I'll fix it with updated version.

--
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  MichaÅ "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/