Re: [PATCH v5 5/9] KVM: MMU: introduce gfn_to_page_many_atomic()function

[Avi Kivity]

On 07/12/2010 05:55 AM, Xiao Guangrong wrote:
> > > @@ -1011,6 +1021,23 @@ pfn_t gfn_to_pfn_memslot(struct kvm *kvm,
> > >        return hva_to_pfn(kvm, addr, false);
> > >    }
> > >
> > > +int gfn_to_page_many_atomic(struct kvm *kvm, gfn_t gfn,
> > > +                struct page **pages, int nr_pages, bool *enough)
> > > +{
> > > +    unsigned long addr;
> > > +    int entry, ret;
> > > +
> > > +    addr = gfn_to_hva_many(kvm, gfn,&entry);
> > > +    if (kvm_is_error_hva(addr))
> > > +        return -1;
> > > +
> > > +    entry = min(entry, nr_pages);
> > > +    *enough = (entry == nr_pages) ? true : false;
> > >
> > >        
>
> > Why not return 0 if !enough?
> >
> >      
> I think it's better that handle the reset pages in the slot, for example,
> we expect 16 pages are consecutive, but only 12 pages in the slot, the better
> way is handle the reset 12 pages not throw those away.

It will almost never happen, let's remove edge cases.




--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/