Re: [PATCH 3/6] writeback: avoid unnecessary calculation of bdidirty thresholds

From: Andrew Morton
Date: Mon Jul 12 2010 - 17:57:23 EST


On Sun, 11 Jul 2010 10:06:59 +0800
Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:

> +void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty)
>
> ...
>
> +unsigned long bdi_dirty_limit(struct backing_dev_info *bdi,
> + unsigned long dirty)

It'd be nice to have some documentation for these things. They're
non-static, non-obvious and are stuffed to the gills with secret magic
numbers.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/