Re: [RFC 3/3] mm: iommu: The Virtual Contiguous Memory Manager

[FUJITA Tomonori]

On Tue, 13 Jul 2010 10:02:23 +0100
Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:

> On Tue, Jul 13, 2010 at 05:45:39PM +0900, FUJITA Tomonori wrote:
> > Drivers can tell the USB layer that these are vmapped buffers? Adding
> > something to struct urb? I might be totally wrong since I don't know
> > anything about the USB layer.
> 
> With non-DMA coherent aliasing caches, you need to know where the page
> is mapped into the virtual address space, so you can deal with aliases.
> 
> You'd need to tell the USB layer about the other mappings of the page
> which you'd like to be coherent (such as the vmalloc area - and there's
> also the possible userspace mapping to think about too, but that's
> a separate issue.)
> 
> I wonder if we should have had:
> 
> 	vmalloc_prepare_dma(void *, size_t, enum dma_direction)
> 	vmalloc_finish_dma(void *, size_t, enum dma_direction)
> 
> rather than flush_kernel_vmap_range and invalidate_kernel_vmap_range,
> which'd make their use entirely obvious.
> 
> However, this brings up a question - how does the driver (eg, v4l, xfs)
> which is preparing the buffer for another driver (eg, usb host, block
> dev) know that DMA will be performed on the buffer rather than PIO?
> 
> That's a very relevant question, because for speculatively prefetching
> CPUs, we need to invalidate caches after a DMA-from-device operation -
> but if PIO-from-device happened, this would destroy data read from the
> device.
> 
> That problem goes away if we decide that PIO drivers must have the same
> apparant semantics as DMA drivers - in that data must end up beyond the
> point of DMA coherency (eg, physical page) - but that's been proven to
> be very hard to achieve, especially with block device drivers.

Yeah, the last thing we want to do is converting all the PIO drivers.

Seems that we are far from the original discussion (the most of the
above topics have been discussed in the past and we kinda agree that
we have to do something some time, I guess).


Zach Pfeffer said this new VCM infrastructure can be useful for
video4linux. However, I don't think we need 3,000-lines another
abstraction layer to solve video4linux's issue nicely.

I can't find any reasonable reasons that we need to merge VCM; seems
that the combination of the current APIs (or with some small
extensions) can work for the issues that VCM tries to solve.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/