Re: [PATCH 1/2] xfs: don't block on buffer read errors

[Christoph Hellwig]

Looks good, except that I'd rework the snipplet below

>  	status = xfs_buf_iorequest(bp);
> -	if (!status && !(flags & XBF_ASYNC))
> +	if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
>  		status = xfs_buf_iowait(bp);
>  	return status;

as:

	if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
		return status;
	return xfs_buf_iowait(bp);

to make it a bit more clear.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/