Re: [PATCH] blkdev: cgroup whitelist permission fix

From: Chris Wright
Date: Thu Jul 15 2010 - 11:55:32 EST


* Chris Wright (chrisw@xxxxxxxxxxxx) wrote:
> The cgroup device whitelist code gets confused when trying to grant
> permission to a disk partition that is not currently open. Part of
> blkdev_open() includes __blkdev_get() on the whole disk. This simply
> avoids the cgroup check for the whole disk case when opening a
> partition.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=589662
>
> Acked-by: Serge E. Hallyn <serue@xxxxxxxxxx>
> Tested-by: Serge E. Hallyn <serue@xxxxxxxxxx>
> Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>

Andrew, plans to push this on? Christoph doesn't like the whole of
blockdev whitelisting for good reason, but it's currently in use and
has this bug.

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/