Re: [PATCH 3/4] KVM: MMU: track dirty page in speculative path properly

From: Xiao Guangrong
Date: Thu Jul 15 2010 - 22:03:16 EST




Marcelo Tosatti wrote:

>> It uses access bit to track both page accessed and page dirty, and it's rather cheap...
>
> Xiao,
>
> I don't understand it. What are you trying to achieve?
>

Marcelo,

The issue which we try to fix in this patch is we mark the page dirty in speculative
path, i'm not sure that after Lai's patch this bug is gone, if it's true, this patch
is not needed anymore, otherwise the later patch is the cheaper way help us to fix this
issue.

In the later patch, we use pte.a to track whether the speculative mapping is accessed,
if it's accessed, we mark the page dirty, just like tracking page-accessed.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/