Re: [PATCH 2/8] Basic zcache functionality

[Pekka Enberg]

Nitin Gupta wrote:
> +static void zcache_add_stat(struct zcache_pool *zpool,
> +		enum zcache_pool_stats_index idx, s64 val)
> +{
> +	struct zcache_pool_stats_cpu *stats;
> +
> +	preempt_disable();
> +	stats = __this_cpu_ptr(zpool->stats);
> +	u64_stats_update_begin(&stats->syncp);
> +	stats->count[idx] += val;
> +	u64_stats_update_end(&stats->syncp);
> +	preempt_enable();
> +
> +}

You should probably use this_cpu_inc() here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/