Re: [PATCH 1/4] posix-timers: Refactoring of CPUCLOCK* macros

From: Daniel Walker
Date: Mon Jul 19 2010 - 17:02:37 EST


On Mon, 2010-07-19 at 22:59 +0200, Tomasz Buchert wrote:
> Daniel Walker a Ãcrit :
> > On Mon, 2010-07-19 at 13:34 +0200, Tomasz Buchert wrote:
> >> This is merely a preparation to introduce wall time
> >> clocks for threads/processes. All occurences of
> >> CPUCLOCK* macros were replaced by CLOCK*.
> >
> > It seems like it would be better to make this naming more specific that
> > less. Couldn't you say "POSIX_CLOCK" or something like that?
> >
> > Daniel
> Hi Daniel.
> Sure. However, technically, my wall clocks have nothing to do
> with POSIX. Still the code is inside a file with "posix" prefix,
> so you are right.
> I will resend patch series as soon as it is done. Could you
> elaborate on another patches?

I wasn't suggesting that adding "POSIX" is the only option, but adding
something more so it's not just "CLOCK" .

You mean you want me to review the other patches also ?

Daniel

--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/