Re: [PATCH 2/3] mfd: MAX8998: Add interrupts support

[Mark Brown]

On Tue, Jul 20, 2010 at 03:57:37PM +0900, Joonyoung Shim wrote:
> Use genirq and provide seperated file for interrupts support.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>

...

> +
> +	for (i = 0; i < ARRAY_SIZE(max8998->irq_masks_cur); i++) {
> +		/*
> +		 * If there's been a change in the mask write it back
> +		 * to the hardware.
> +		 */
> +		if (max8998->irq_masks_cur[i] != max8998->irq_masks_cache[i]) {
> +			max8998->irq_masks_cache[i] = max8998->irq_masks_cur[i];
> +			max8998_write_reg(max8998->i2c, MAX8998_REG_IRQM1 + i,
> +					max8998->irq_masks_cur[i]);
> +		}

This code all looks oddly familiar :)

Reviewed-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/