Re: [PATCH 1/12] ad1836: fix a memory leak if another ad1836 is registered

[Barry Song]

On Thu, Jul 15, 2010 at 10:50 AM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> ad1836 is allocated in ad1836_spi_probe() but is not freed if ad1836_register()
> return -EINVAL (if another ad1836 is registered).
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Acked-by: Barry Song <21cnbao@xxxxxxxxx>

> ---
> Âsound/soc/codecs/ad1836.c | Â Â1 +
> Â1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/ad1836.c b/sound/soc/codecs/ad1836.c
> index 2175384..a01006c 100644
> --- a/sound/soc/codecs/ad1836.c
> +++ b/sound/soc/codecs/ad1836.c
> @@ -272,6 +272,7 @@ static int ad1836_register(struct ad1836_priv *ad1836)
>
> Â Â Â Âif (ad1836_codec) {
> Â Â Â Â Â Â Â Âdev_err(codec->dev, "Another ad1836 is registered\n");
> + Â Â Â Â Â Â Â kfree(ad1836);
> Â Â Â Â Â Â Â Âreturn -EINVAL;
> Â Â Â Â}
>
> --
> 1.5.4.3
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/