Re: [PATCH 02/10] x86, xsave: 32/64 bit boot cpu check unificationin initialization

From: Suresh Siddha
Date: Tue Jul 20 2010 - 17:48:20 EST


On Tue, 2010-07-20 at 11:50 -0700, Robert Richter wrote:
> Boot cpu id is always 0, thus simplifying and unifying boot cpu check.
>
> boot_cpu_id is there for historical reasons and was renamed to
> boot_cpu_physical_apicid in patch:
>
> c70dcb7 x86: change boot_cpu_id to boot_cpu_physical_apicid
>
> However, there are some remaining occurrences of boot_cpu_id that are
> never touched in the kernel and thus its value is always 0.
>
> Signed-off-by: Robert Richter <robert.richter@xxxxxxx>
> ---
> arch/x86/kernel/cpu/common.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 3f715ef..26804b2 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1273,7 +1273,7 @@ void __cpuinit cpu_init(void)
> /*
> * Boot processor to setup the FP and extended state context info.
> */
> - if (smp_processor_id() == boot_cpu_id)
> + if (!smp_processor_id())
> init_thread_xstate();
>
> xsave_init();

Acked-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/