Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added

From: MichaÅ Nazarewicz
Date: Wed Jul 21 2010 - 14:39:56 EST


On Wed, 21 Jul 2010 20:24:58 +0200, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

On Wed, Jul 21, 2010 at 04:31:35PM +0200, Micha?? Nazarewicz wrote:
On Wed, 21 Jul 2010 15:52:30 +0200, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> If this does need to be configured per system would having platform data
> of some kind in the kernel not be a sensible a place to do it,

The current version (and the next version I'm working on) of the code
has cma_defaults() call. It is intended to be called from platform
initialisation code to provide defaults.

So the command line is just a way of overriding that? That makes things
a lot nicer - normally the device would use the defaults and the command
line would be used in development.

Correct.

> or even
> having a way of configuring this at runtime (after all, the set of
> currently active users may vary depending on the current configuration
> and keeping everything allocated all the time may be wasteful)?

I am currently working on making the whole thing more dynamic. I imagine
the list of regions would stay pretty much the same after kernel has
started (that's because one cannot reliably allocate new big contiguous
memory regions) but it will be possible to change the set of rules, etc.

Yes, I think it will be much easier to be able to grab the regions at
startup but hopefully the allocation within those regions can be made
much more dynamic. This would render most of the configuration syntax
unneeded.

Not sure what you mean by the last sentence. Maybe we have different
things in mind?

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, MichaÅ "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/