Re: [PATCH] USB: core: Choose configuration with lowest bConfigurationValue

From: Alan Stern
Date: Thu Jul 22 2010 - 10:22:47 EST


On Thu, 22 Jul 2010, Michal Nazarewicz wrote:

> This patch removes code from usb_choose_configuration()
> responsible for ignoring the first USB device configuration if
> its first interface is RNDIS. Instead,
> usb_choose_configuration() chooses configuration with lowest
> bConfigurationValue. Linux' Ethernet gadget uses a lower
> bConfigurationValue for the second configuration which is
> a CDC configuration so this code should choose configuration
> that suits Linux better.

I don't like this idea. Choosing configs is a sensitive topic, since
it is highly visible to users. It should be changed minimally, if at
all.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/