Re: [patch 1/3] hpet: factor timer allocate from open

[Thomas Gleixner]

On Tue, 20 Jul 2010, akpm@xxxxxxxxxxxxxxxxxxxx wrote:

> From: Magnus Lynch <maglyx@xxxxxxxxx>
> 
> The current implementation of the /dev/hpet driver couples opening the
> device with allocating one of the (scarce) timers (aka comparators).  This
> is a limitation in that the main counter may be valuable to applications
> seeking a high-resolution timer who have no use for the interrupt
> generating functionality of the comparators.

And how exactly does this patch provide such functionality ? There is
no interface which allows you to access the counter itself. All what
this patch does is removing the allocation from open() and sprinkle
the allocation all over the place for _ZERO_ benefit.

I really have a hard time to understand why anything would open
/dev/hpet just to do nothing with it.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/