Re: [RFC] x86: perf swallows all NMIs when registered with a user

[Yinghai Lu]

On 07/23/2010 05:55 AM, Don Zickus wrote:
> On Thu, Jul 22, 2010 at 03:58:21PM -0700, Yinghai Lu wrote:
>> cool, with your patch and following patch i can use nmi button now with CONFIG_LOCKUP_DETECTOR defined
>>
>> [PATCH] x86,nmi: move unknown_nmi_panic to traps.c
>>
>> So we use it even LOCKUP_DETECTOR is defined.
>>
>> need Don's patch...
> 
> Thanks for the feedback Yinghai!
>>
>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> 
> With regards to your patch, I am still a little uncomfortable with it, as
> it seems to be redundant with what is used in unknown_nmi_error() and the
> panic_on_unrecovered_nmi flag.  I agree that keeping the familiar flag
> 'unknown_nmi_panic' is needed.  But I was still wondering if wrapping it
> around 'panic_on_unrecovered_nmi' would be simpler and less code.

how about the one in sysctl?

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/