Re: [PATCH] of: Provide default of_node_to_nid() when CONFIG_NUMAis not set

[Grant Likely]

[cc'ing Arnd]

On Sun, Jul 25, 2010 at 02:37:38PM -0600, Grant Likely wrote:
> On Sat, Jul 24, 2010 at 9:07 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> > Hi Grant,
> >
> > On Sat, 24 Jul 2010 09:43:31 -0600 Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> >>
> >> of_node_to_nid() is only relevant for NUMA.  Don't force architectures to
> >> implement it if CONFIG_NUMA is not set.
> >
> > Why not just do:
> >
> > #ifndef of_node_to_nid
> > static inline int of_node_to_nid(struct device_node *device) { return 0; }
> > #define of_node_to_nid  of_node_to_nid
> > #endif
> >
> > in include/linux/of.h
> >
> > and then add:
> >
> > #define of_node_to_nid  of_node_to_nid
> >
> > Where it is declared/defined for each arch ...
> > (it would be nice if all the archs were consistent in where it was
> > declared).
> 
> Two reasons; I had started doing that in topology.h, but it caused a
> bunch of collateral damage with files missing the include, so I punted
> and took the easy way out.  Also, I didn't know if that was an
> acceptable or safe pattern for override symbols.
> 
> I'll spin it again with this pattern and see what it looks.
> 
> g.

Should I use asm-generic for this and other similar symbols?  How does the following look?

---