Re: [PATCH] Tight check of pfn_valid on sparsemem - v3

From: Minchan Kim
Date: Sun Jul 25 2010 - 18:26:33 EST


2010/7/26 Penttilä Mika <mika.penttila@xxxxxxxxxx>:
> I don't think this works because if the memmap pages get reused, the corresponding struct page->private could be used by chance in such a way that it has the value of MEMMAP_HOLE. Of course unlikely but possible. And after all the whole point of freeing part of the memmap is that it could be reused.
>

You're absolutely right.
Previous version, I didn't do such as.
In this version, I wanted to remove dependency of page->private and
mem_section to identify hole memmap for using it in FLATMEM of ARM but
make mistake.
I will resend the patch

Thanks for careful review.

> --Mika
>
>
>
>



--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/