Re: [PATCH -next] staging/line6: needs to select SND_PCM

[Takashi Iwai]

At Tue, 27 Jul 2010 12:21:19 -0700,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> line6 uses snd_pcm*() functions, so it should select SND_PCM.
> 
> ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined!
> ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined!
> ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined!
> ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined!
> ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined!
> ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined!
> ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined!
> ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined!
> ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: Markus Grabner <grabner@xxxxxxxxxxxxx>
> ---
>  drivers/staging/line6/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Third patch to staging/line6/Kconfig.  :(
> Developers should know what kernel services their code needs
> and how to configure for those needs.

I think this should be applied rather to 2.6.35 tree.


thanks,

Takashi

> --- linux-next-20100727.orig/drivers/staging/line6/Kconfig
> +++ linux-next-20100727/drivers/staging/line6/Kconfig
> @@ -2,6 +2,7 @@ config LINE6_USB
>  	tristate "Line6 USB support"
>  	depends on USB && SND
>  	select SND_RAWMIDI
> +	select SND_PCM
>  	help
>  	  This is a driver for the guitar amp, cab, and effects modeller
>  	  PODxt Pro by Line6 (and similar devices), supporting the
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/