Re: [PATCH] musb: move usb_add_hcd to the core init code from gadgetcode (v2)

From: Bryan Wu
Date: Fri Jul 30 2010 - 00:53:29 EST


On 07/23/2010 11:28 PM, Sergei Shtylyov wrote:
> Hello.
>
> Bryan Wu wrote:
>
>> BugLink: http://bugs.launchpad.net/bugs/608312
>
>> v2:
>> fix the building error on latest 2.6.35-rc kernel, since v1 was
>> generated in
>> 2.6.33 kernel.
>
> The remarks about patch changes should follow the --- tear line.
>

Thanks Sergei, I will take care of it in the future.

Any other comments about this patch?

Felipe, could you please take a look? or need I ping you in the Facebook, -:))

-Bryan

>> v1:
>> usb_add_hcd was only called when we insmod the gadget class module or
>> built-in
>> that gadget class driver. If musb is configured as OTG controller, we
>> need to
>> insmod or built-in gadget class driver to make our Host mode fucntion
>> works.
>
>> In our Ubuntu system, normally we compiled all the gadget class
>> drivers as
>> modules. Then users can insmod the gadget modules as they want. But
>> without the
>> gadget class driver running, we needs host function to support common USB
>> devices.
>
>> This patch fix this issue and tested on omap3 beagle board and Gumstix
>> board.
>
>> Signed-off-by: Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
>
> WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/