Re: [PATCH] PCI: MSI: Restore read_msi_msg_desc(); addget_cached_msi_msg_desc()

From: Jesse Barnes
Date: Fri Jul 30 2010 - 12:43:00 EST


On Fri, 23 Jul 2010 14:56:28 +0100
Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> wrote:

> commit 2ca1af9aa3285c6a5f103ed31ad09f7399fc65d7 "PCI: MSI: Remove
> unsafe and unnecessary hardware access" changed read_msi_msg_desc() to
> return the last MSI message written instead of reading it from the
> device, since it may be called while the device is in a reduced
> power state.
>
> However, the pSeries platform code really does need to read messages
> from the device, since they are initially written by firmware.
> Therefore:
> - Restore the previous behaviour of read_msi_msg_desc()
> - Add new functions get_cached_msi_msg{,_desc}() which return the
> last MSI message written
> - Use the new functions where appropriate
>
> Signed-off-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
> ---
> Compile-tested only.
>

Applied to linux-next with Michael's ack, thanks. I hope it actually
works, I didn't see a tested-by!

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/