Re: [PATCHv5 1/3] USB: gadget: composite: Better string overridehandling

From: MichaÅ Nazarewicz
Date: Mon Aug 02 2010 - 05:46:50 EST

On Sun, 01 Aug 2010 21:05:33 +0200, David Brownell <david-b@xxxxxxxxxxx> wrote:
NAK. You're still hard-wiring an un-managed serial number.

Uh? I'm not. Current code overrides the serial number only when the
iSerial module parameter is given:

+ if (iSerialNumber)
+ cdev->serial_override =
+ override_id(cdev, &cdev->desc.iSerialNumber);

and when host requests string which ID is saved as a overridden for
serial number the module parameter is taken.

+ else if (cdev->serial_override == id)
+ str = iSerialNumber;

Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, MichaÅ "mina86" Nazarewicz (o o)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at