Re: [PATCH -v3 2/2] x86: more early console output fromcompressed/misc.c
From: Cyrill Gorcunov
Date: Mon Aug 02 2010 - 13:49:26 EST
On Mon, Aug 02, 2010 at 02:18:39AM -0700, Yinghai Lu wrote:
> will get
> |Decompressing Linux... Parsing ELF... done.
> |Booting the kernel.
> in serial console.
> reuse code from arch/x86/boot/
> and we can use printf if needed
> -v2: define BOOT_BOOT_H to avoid include boot.h
> -v3: early_serial_base need to be static in misc.c ?
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> arch/x86/boot/compressed/misc.c | 65 +++++++++++++++++++++++++++++++++++++++-
> arch/x86/boot/main.c | 6 +--
> 2 files changed, 66 insertions(+), 5 deletions(-)
It seems eventually we just add ~80 lines of code in compare with what we had before,
just to print "Decompressing..." by serial line. Not sure Yinghai if it worth
it. Though having printf that early might be quite useful for those who debugging
or developing new compressors/decompressors. If it would be small non-intrusive
patch I would both hands for it but now I simply don't know (to be fair mine
proposal based on your initial patch not better either ;)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/