Re: [PATCH] Staging: wlan-ng: remove typedef in p80211ioctl.h

From: Arnd Bergmann
Date: Tue Aug 03 2010 - 09:24:16 EST

On Saturday 31 July 2010, Edgardo Hames wrote:
> -typedef struct p80211ioctl_req {
> +struct p80211ioctl_req {
> caddr_t data;
> u32 magic;
> u16 len;
> u32 result;
> -} __attribute__ ((packed)) p80211ioctl_req_t;
> +} __attribute__ ((packed));

BTW, this data structure is broken and needs fixing.
Putting a pointer in there means that it's incompatible
between 32 and 64 bit user space, among other problems.

The TODO list for this driver already contains "move to
use the in-kernel wireless stack", which should consequently
imply getting rid of this p80211knetdev_do_ioctl function, but
it may be useful to list that as a separate item.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at