Re: [PATCH 1/2]drivers/usb/core/sysfs.c Fix variable 'retval' setbut not used

From: Alan Stern
Date: Tue Aug 03 2010 - 11:34:36 EST

On Tue, 3 Aug 2010 Valdis.Kletnieks@xxxxxx wrote:

> > Failure to create a file in sysfs is almost never fatal and usually not
> > even dangerous. Ignoring the error is generally better than failing
> > the entire operation.
> Then why the __must_check attribute if it's usually ignorable? I thought
> that was reserved for functions that you damned sight better well check
> for errors because bad things are afoot otherwise?

That's a good question. Perhaps Greg KH knows the answer.

Alan Stern

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at