Re: [PATCH] trivial, document that div64_u64() is not precise on32bit platforms
From: Andrew Morton
Date: Tue Aug 03 2010 - 18:28:33 EST
On Mon, 2 Aug 2010 18:09:51 +0200
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> We have a bugreport which blames div64_u64() on 32bit platforms.
> However, the code obviously doesn't even try to pretend it can do
> the 64bit division precisely. If there is something in the high
> word of divisor, div64_u64() just shifts both arguments and throws
> out the low bits.
> Add a small comment to avoid the confusion.
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> lib/div64.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> --- a/lib/div64.c
> +++ b/lib/div64.c
> @@ -77,7 +77,10 @@ s64 div_s64_rem(s64 dividend, s32 diviso
> -/* 64bit divisor, dividend and result. dynamic precision */
> + * 64bit divisor, dividend and result. Dynamic precision, unless
> + * divisor fits in u32 result is not exactly correct.
> + */
> #ifndef div64_u64
> u64 div64_u64(u64 dividend, u64 divisor)
Well that was a bit lazy of us - I wonder how hard it is to fix.
At present people will test their code on 64-bit only to find out later
that it doesn't work correctly on 32-bit. Bad. Perhaps we should
similarly break the 64-bit version :)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/