Re: [PATCH v4 0/2] cgroups: implement moving a threadgroup'sthreads atomically with cgroup.procs
From: KAMEZAWA Hiroyuki
Date: Tue Aug 03 2010 - 19:50:35 EST
On Tue, 3 Aug 2010 12:58:27 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 30 Jul 2010 19:56:49 -0400
> Ben Blum <bblum@xxxxxxxxxxxxxx> wrote:
> > This patch series implements a write function for the 'cgroup.procs'
> > per-cgroup file, which enables atomic movement of multithreaded
> > applications between cgroups. Writing the thread-ID of any thread in a
> > threadgroup to a cgroup's procs file causes all threads in the group to
> > be moved to that cgroup safely with respect to threads forking/exiting.
> > (Possible usage scenario: If running a multithreaded build system that
> > sucks up system resources, this lets you restrict it all at once into a
> > new cgroup to keep it under control.)
> I can see how that would be useful. No comments from anyone else?
I think the feature itself is good and useful. I welcome this.
> patch 1/2 makes me cry with all those ifdefs. Maybe helper functions
> would help, but not a lot.
Add static inline functions ?
> patch 2/2 looks very complicated.
yes. that's a concern.
I'd like to look deeper, today.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/