Re: [PATCH v2 2/3] genhd, efi: add efi partition metadata to hd_structs

From: Tejun Heo
Date: Wed Aug 04 2010 - 03:59:12 EST


Hello,

On 08/04/2010 04:04 AM, Will Drewry wrote:
> struct partition_meta_info {
> enum partition_meta_info_format_t format;
> union {
> +#ifdef CONFIG_EFI_PARTITION
> + struct {
> + efi_guid_t uuid;
> + efi_guid_t type;
> + efi_char16_t label[72 / sizeof(efi_char16_t)];
> + } efi;
> +#endif

It would be nice if uuid can be made a common field outside of the
union so that generic code which only cares about UUID can simply read
it off.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/