Re: [PATCH 2.6.37? ] drivers/input: Use pr_<level>
From: Dmitry Torokhov
Date: Wed Aug 04 2010 - 04:04:19 EST
On Wed, Aug 04, 2010 at 12:33:42AM -0700, Joe Perches wrote:
> On Tue, 2010-08-03 at 21:32 -0700, Dmitry Torokhov wrote:
> > Hi Joe,
> Hi Dmitry.
> > On Tue, Aug 03, 2010 at 11:40:50AM -0700, Joe Perches wrote:
> > > Remove prefixes from printks and convert to pr_fmt/pr_<level>.
> > Thanks for doing this, however instead of using pr_xxx() I'd like
> > drivers that are integrated in driver model (serio, usb, gameport, etc,
> > i.e. when we have 'struct device' available, exept for psmouse) to use
> > drv_xxx() instead.
> These files?
> $ grep -rPl --include=*.[ch] "\bstruct\s+device\b" drivers/input | \
> xargs grep -wl pr_fmt
There should be more. USB for example. Basically anything but very old
legacy drivers that never been converted to the 2.6 device model.
> > That would make synaptics messages to come as "psmouse", right?
> > I think we should use
> > #define pr_fmt(fmt) "synaptics: " fmt
> > here and in the rest of specialized PS/2 protocol handlers.
> Perhaps convert to what elantech uses
> #define pr_fmt(fmt) KBUILD_BASENAME ": " fmt
> $ grep -l "define pr_fmt" drivers/input/mouse/*.[ch] | \
> xargs grep -il "ps2"
psmouse-base should use KBUILD_MODNAME, for the rest of these
KBUILD_BASENAME seems to fit.
> Which ones do you want converted?
> Any others?
No, I think this is it as far as PS/2 mice go.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/