Re: [PATCH v4 1/2] cgroups: read-write lock CLONE_THREAD forkingper threadgroup

From: Brian K. White
Date: Wed Aug 04 2010 - 12:43:30 EST



As far as the #ifdef mess goes, it's true that some people don't have
CONFIG_CGROUPS defined. I'd imagine that these are likely to be
embedded systems with a fairly small number of processes and threads
per process. Are there really any such platforms where the cost of a
single extra rwsem per process is going to make a difference either in
terms of memory or lock contention? I think you should consider making
these additions unconditional.

openSUSE's default kernel* doesn't have CONFIG_CGROUPS

Personally I think it's a silly mistake also, since the argument was performance, and ubuntu's desktop kernel has it and actually outperforms openSUSE's, and the feature is perfectly likely to be needed by "desktop" users, but I wasn't and still aren't consulted on this and so it's a fact that must be lived with at least for a while. ;) (at least until the majority of 11.2 and 11.3 installations are replaced due to age, and that's if they reverted the decision today, which so far they haven't)

*("kernel-desktop" the one installed by default, not "kernel-default", which exists but is not installed by default since openSUSE 11.2)

--
bkw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/