Re: [PATCH 2/6] staging: hv: Fixed lockup problem withbounce_buffer scatter list

From: Greg KH
Date: Wed Aug 04 2010 - 13:09:47 EST


On Wed, Aug 04, 2010 at 04:32:17AM +0000, Hank Janssen wrote:
> And then Greg spoke:
> >> On Tue, Aug 03, 2010 at 05:31:53PM +0000, Hank Janssen wrote:
> >> From: Hank Janssen <hjanssen@xxxxxxxxxxxxx>
> > >
> > >Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads.
> >
> >Same questions for you as patch 1/6.
> >
> >Also, please wrap your changelog comments at 72 columns.
>
> Under heavy loads with many clients we this problem appears, it causes a kernel
> Panic.

Great, please provide this info.

> Yes, this should be backported to all stable kernel releases that have the
> Hyper-V drivers In them.

Again, add a cc: stable <stable@xxxxxxxxxx> to the patch please.

> >> Signed-off-by:Hank Janssen <hjanssen@xxxxxxxxxxxxx>
> >> Signed-off-by:Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> >
> >What's with the trailing space?
>
> Same problem as wrapping my comments at 72 chars, I just upgraded to the latest
> Evil outlook 2010, and my settings in office 2007 did not transfer so I have to
> Set up all the stuff that fixes these problems :(
>
> Do you want me to re-submit with correct wrapping?

Yes. But you also have trailing spaces in some of these patches as
well, which need to be addressed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/