Re: [PATCH] U6715 16550A serial driver support

From: Philippe Langlais
Date: Thu Aug 05 2010 - 04:53:16 EST

On 08/05/10 09:22, Andrew Morton wrote:
On Thu, 5 Aug 2010 09:14:40 +0200 Philippe Langlais<philippe.langlais@xxxxxxxxxxxxxx> wrote:

The patch adds these .set_termios hooks but doesn't actually use them
for anything.

The changelog doesn't tell us _why_ this was done (it should) and
lacking any code to look at it's all a bit mysterious.

This feature is used in our U6715 8250 platform serial driver, to avoid
hack in 8250.c set_termios (Alan Cox requirement).
In this driver the input uart clock frequency depends on baud rate and
is computed in our set_termios override function.
The U6715 paltform serial patch has been submitted on linux-arm mailing
and is ready to enter Russell King Linux tree.

More things to do ?
Update the changelog to include this rather important information.
Ok is done
As the patches are dependent, treat them as a single series. Russell
can merge them both with Greg's ack or Greg can merge them both with
Russell's ack.

This patch can be merged before U6715 platform one without problem.
Where I post the series in linux-kernel or linux-arm or both mailing lists ?
Greg has already taken this patch in its linux-next tree, need to resend to him the patch with new comments ?
All U6715 platform patches are already posted in linux-arm mailing list.
It's my first contribution and I don't know how to proceed.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at