Re: [PATCH 2/2] usb gadget: don't save bind callback in structusb_configuration
From: MichaÅ Nazarewicz
Date: Thu Aug 05 2010 - 05:04:27 EST
On Mon, 02 Aug 2010 20:27:46 +0200, Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
The bind function is only called at init time so there is no need to
save a pointer to it in the driver struct.
This is not entirely true. How about such wording:
The bind function is often called only at init time so there is no neet
to save a pointer to it in the configuration structure.
Also note, that if you are fixing composite gadgets as well, there's also
usb_composite_driver structure and accompanying usb_composite_register()
Other then that, for what it's worth, the patch looks good to me.
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, MichaÅ "mina86" Nazarewicz (o o)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/