Re: [PATCH 1/2] lp3971: remove unnecessary ret value checking in lp3971_i2c_write()

From: Axel Lin
Date: Thu Aug 05 2010 - 10:22:38 EST

hi Mark,

2010/8/5 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>:
> On Thu, Aug 05, 2010 at 11:40:38AM +0800, Axel Lin wrote:
>> i2c_smbus_write_byte_data() returns zero or negative value,
>> therefore no need to check if ret is greater than zero or not.
>> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> but can I once more renew my request that you make some effort to
> provide subject lines for your patches which are consistent with the
> standard used for the area of the kernel you're submitting to?

I think we have communication problem.
I thought the subject "[PATCH 1/2] lp3971: remove unnecessary ret
value checking in lp3971_i2c_write()"
is pretty clear.
Or do you mean something else?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at