Re: [spi-devel-general] [PATCH 26/42] drivers/spi/amba-pl022.c: Adjust confusing if indentation

From: Linus Walleij
Date: Thu Aug 05 2010 - 17:41:17 EST

2010/8/5 Julia Lawall <julia@xxxxxxx>:

> From: Julia Lawall <julia@xxxxxxx>
> The return -EINVAL appears to only make sense if the if branch that it is
> aligned with is taken, so move it into that branch

What a nasty bug to see, thanks for robot-finding this!
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at